Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade morango. #12408

Merged
merged 3 commits into from
Jul 4, 2024
Merged

Upgrade morango. #12408

merged 3 commits into from
Jul 4, 2024

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jul 3, 2024

Summary

  • Upgrades morango to fix a regression caused by the Django 3.2 upgrade
  • Upgrades to a morango version that supports Python 3.12

References

…

Reviewer guidance

…

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Jul 3, 2024
marcellamaki
marcellamaki approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@marcellamaki marcellamaki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the latest morango release, which contains the upgrade to python 3.12 PR. but let's wait for manual QA before merge

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024 •
edited
Loading

Build Artifacts

Asset type Download link
PEX file kolibri-.pex
Windows Installer (EXE) kolibri-0.17.0a0.dev0+git.247.g3d7d99a6-windows-setup-unsigned.exe
Debian Package kolibri_0.17.0a0.dev0+git.247.g3d7d99a6-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.17.0a0.dev0+git.247.g3d7d99a6-0.4.2.dmg
Android Package (APK) kolibri-0.17.0a0.dev0+git.247.g3d7d99a6-0.1.3-debug.apk
TAR file kolibri-0.17.0a0.dev0+git.247.g3d7d99a6.tar.gz
WHL file kolibri-0.17.0a0.dev0+git.247.g3d7d99a6-py2.py3-none-any.whl

@github-actions github-actions bot added the DEV: dev-ops Continuous integration & deployment label Jul 3, 2024
@radinamatic
Copy link
Member

No issues observed after installing the assets on Windows 10 and Ubuntu 18.04, major features (imported resources, user & classes created, lesson & quiz assigned) all a-Ok! 💯

Ubuntu 18.04 Windows 10
morango-Ubuntu18 04 morango-windows

radinamatic
radinamatic approved these changes Jul 3, 2024
View reviewed changes
Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passes, good to go! 💯 👍🏽 :shipit:

@rtibbles
Copy link
Member Author

rtibbles commented Jul 3, 2024

The full morango integration tests have not quite run just yet, so I am going to rebase and force push to try to trigger them here.

@github-actions github-actions bot added the DEV: backend Python, databases, networking, filesystem... label Jul 3, 2024
@rtibbles
Copy link
Member Author

rtibbles commented Jul 4, 2024

Integration tests are all passing. Only test failure is a known flaky test on MacOS that has nothing to do with these changes.

@rtibbles rtibbles merged commit a1767ba into learningequality:develop Jul 4, 2024
37 of 38 checks passed
@rtibbles rtibbles deleted the morango_081 branch July 4, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcellamaki marcellamaki marcellamaki approved these changes

@radinamatic radinamatic radinamatic approved these changes

Assignees
No one assigned
Labels
DEV: backend Python, databases, networking, filesystem... DEV: dev-ops Continuous integration & deployment TODO: needs review Waiting for review
Projects
None yet
Milestone
Kolibri 0.17: General maintenance, bu...
Development

Successfully merging this pull request may close these issues.
3 participants
@rtibbles @radinamatic @marcellamaki