make sure the question count v-model uses .number #12407
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12406 by adding
.number
to the questionCount v-model. I think this is okay, but alternatively I could update the increment toparseInt()
if that's preferableReferences
add-not-concat.mp4
Reviewer guidance
In develop, input a number of questions typing into the textbox (i.e. 5) and then click the "+" button. You should see 51, rather than 6.
Checkout PR, and do the same. It should add the value, not concat as strings
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)