-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EQM: What happens when I refresh? #12393
EQM: What happens when I refresh? #12393
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes make sense - if @radinamatic signs off, this is good to go!
This still needs some work: refreshing the page always (after adding or deleting sections) gives me the refresh.mp4As I expected, the default browser alert popup/modal, is fully keyboard navigable 🙂 |
@radinamatic thank you! I've updated the PR to account for the case you ran into! Should now be the case that if you ever are on a section which doesn't exist in the URL parameters, then we redirect you to the first section, which should always exist by the nature of how the useQuizCreation module works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have verified the updates since @radinamatic's review. All working with no errors in the console, and properly redirecting to an existent section on refresh!
Summary
Makes some changes to improve behavior on page refresh, such that:
beforeunload
event and uses the close confirmation message in it. I tried to inject our modal but thebeforeunload
event doesn't really allow for that so I used our message there.References
Fixes #12390
Reviewer guidance
Try refreshing the page in various places.
If the quiz is one you've saved before, then you should reload to the place you were at, but without your changes having been saved.
But! When you refresh on the replacements page, you should see the page load up with the side panel having been closed.
a11y