Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EQM: Sections for quiz detail page #12384

Merged
merged 5 commits into from
Jul 4, 2024
Merged

EQM: Sections for quiz detail page #12384

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cbc4207
fix errors causing issues when one section only
nucleogenesis Jul 1, 2024
7481f9c
accordion & kselects for section/question nav in quiz details
nucleogenesis Jul 1, 2024
683a933
cleanpu
nucleogenesis Jul 1, 2024
37c495c
revert changes to attemptloglist
nucleogenesis Jul 1, 2024
d2b3215
update questionlistpreview to use improved data structure
nucleogenesis Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions kolibri/core/assets/src/views/AttemptLogList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@
displaySectionTitle,
enhancedQuizManagementStrings,
} from 'kolibri-common/strings/enhancedQuizManagementStrings';
import { coreStrings } from 'kolibri.coreVue.mixins.commonCoreStrings';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't use import coreStrings from 'kolibri.utils.coreStrings from here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is outdated but I get errors on my end locally without changing the import here.

import useAccordion from 'kolibri-common/components/useAccordion';
import coreStrings from 'kolibri.utils.coreStrings';
import AccordionItem from 'kolibri-common/components/AccordionItem';
import AccordionContainer from 'kolibri-common/components/AccordionContainer';
import { computed, onMounted, watch } from 'kolibri.lib.vueCompositionApi';
Expand All @@ -169,9 +169,9 @@
AccordionItem,
},
setup(props, { emit }) {
const { sections, selectedQuestionNumber } = toRefs(props);
const { questionsLabel$, quizSectionsLabel$ } = enhancedQuizManagementStrings;
const { questionNumberLabel$ } = coreStrings;
const { currentSectionIndex, sections, selectedQuestionNumber } = toRefs(props);

const { expand, isExpanded, toggle } = useAccordion(sections);

Expand All @@ -189,6 +189,17 @@
}));
});

const currentSectionIndex = computed(() => {
let qCount = 0;
for (let i = 0; i <= sections.value.length; i++) {
qCount += sections.value[i].questions.length;
if (qCount > selectedQuestionNumber.value) {
return i;
}
}
return 0;
});

nucleogenesis marked this conversation as resolved.
Show resolved Hide resolved
const currentSection = computed(() => {
return sections.value[currentSectionIndex.value];
});
Expand Down Expand Up @@ -230,6 +241,7 @@
handleSectionChange,
handleQuestionChange,
displaySectionTitle,
questionNumberLabel$,
nucleogenesis marked this conversation as resolved.
Show resolved Hide resolved
quizSectionsLabel$,
questionsLabel$,
expand,
Expand Down
Loading