Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display question titles with displayQuestionTitle #12369

Merged

Conversation

LianaHarris360
Copy link
Member

Summary

This pull request modifies user-facing question titles to be displayed using displayQuestionTitle. User-facing section titles have been updated to use displaySectionTitle in the PR #12363

Before After
Before1 After1
Before2 After2

References

Closes #12294

Reviewer guidance

  1. Create a quiz
  2. Navigate to the Plan Coach tab and select the quiz to see a preview of the questions

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Jun 26, 2024
@LianaHarris360 LianaHarris360 changed the title Add question titles with displayQuestionTitle Display question titles with displayQuestionTitle Jun 26, 2024
Copy link
Member

@AllanOXDi AllanOXDi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Looks great! Thanks @LianaHarris360

@rtibbles rtibbles merged commit dc7a843 into learningequality:develop Jun 27, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EQM: Replace user-facing section_title with displaySectionTitle throughout (same for questions)
3 participants