EQM: Bookmarks not linking anywhere in resource selection #12360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Coach
nucleogenesis
added
TODO: needs review
Build Artifacts
|
pcenov
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
Thanks @nucleogenesis - I confirm that the issue described in #12331 is fixed now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12331
The
contentLinkmethod inResourceSelectionwas returning an empty object with the expectation that it would basically serve as a no-op which worked find except for the fact that we show bookmarks based on a query param.This returns the current route's
nameparamsandqueryfor non-topic content nodes. I think I worried that this approach would result in redundant navigation errors but it seems that router-link just ignores clicks on the links.Reviewer guidance
Test clicking bookmarks and exercise cards in EQM resource selection.