Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added neeeded values for BaseValuesViewset #12346

Merged

Conversation

jredrejo
Copy link
Member

@jredrejo jredrejo commented Jun 21, 2024

Summary

NetworkLocationFacilitiesView had been changed to use BaseValuesViewset instead of viewsets.GenericViewSet
But reference values had not been added. This PR fixes it

References

Closes #12299

Reviewer guidance

Try to reproduce the use case in #12299

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@jredrejo jredrejo added the TODO: needs review Waiting for review label Jun 21, 2024
@jredrejo jredrejo requested review from rtibbles and pcenov June 21, 2024 10:22
@github-actions github-actions bot added the DEV: backend Python, databases, networking, filesystem... label Jun 21, 2024
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jredrejo - importing facilities is working correctly again!

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, looks like I caused this in attempting to prevent introspection errors from drf-yasg.

@rtibbles rtibbles merged commit 436954a into learningequality:develop Jun 24, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

500 error when importing facility from different device
3 participants