Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional strings #12336

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Additional strings #12336

merged 3 commits into from
Jun 20, 2024

Conversation

marcellamaki
Copy link
Member

This PR

Fixes #11757

and adds the string needed for #11882 (WIP PR from @LianaHarris360 #12310 - bug to be resolved after)

@marcellamaki marcellamaki requested a review from rtibbles June 20, 2024 19:23
@github-actions github-actions bot added APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend SIZE: very small labels Jun 20, 2024
radinamatic
radinamatic approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏽 💯 :shipit:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 20, 2024 •
edited
Loading

Build Artifacts

Asset type Download link
PEX file kolibri-.pex
Windows Installer (EXE) kolibri-0.17.0a0.dev0+git.48.gfa3c43c4-windows-setup-unsigned.exe
Debian Package kolibri_0.17.0a0.dev0+git.48.gfa3c43c4-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.17.0a0.dev0+git.48.gfa3c43c4-0.4.2.dmg
Android Package (APK) kolibri-0.17.0a0.dev0+git.48.gfa3c43c4-0.1.3-debug.apk
TAR file kolibri-0.17.0a0.dev0+git.48.gfa3c43c4.tar.gz
WHL file kolibri-0.17.0a0.dev0+git.48.gfa3c43c4-py2.py3-none-any.whl

@github-actions github-actions bot added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) SIZE: small labels Jun 20, 2024
@rtibbles rtibbles merged commit 9fd15ee into learningequality:develop Jun 20, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtibbles rtibbles rtibbles approved these changes

@radinamatic radinamatic radinamatic approved these changes

Assignees
No one assigned
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend SIZE: small SIZE: very small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correct currently commented-out string to reference '0.15 and greater' and reinstate it
3 participants
@marcellamaki @radinamatic @rtibbles