Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ordering for FacilityUser viewset #12324

Merged

Conversation

ozer550
Copy link
Member

@ozer550 ozer550 commented Jun 20, 2024

Summary

Supports ordering from the backend for facility users.

References

closes #12234

Reviewer guidance

pytest kolibri/core/auth/test/test_api.py -k FacilityUserOrderingTestCase

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@ozer550 ozer550 requested a review from rtibbles June 20, 2024 06:41
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: medium labels Jun 20, 2024
@rtibbles rtibbles self-assigned this Jul 16, 2024
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One slight tweak in implementation, one slight tweak in tests.

kolibri/core/auth/api.py Outdated Show resolved Hide resolved
kolibri/core/auth/test/test_api.py Outdated Show resolved Hide resolved
@ozer550 ozer550 requested a review from rtibbles July 26, 2024 11:25
@rtibbles rtibbles merged commit b0b5624 into learningequality:develop Jul 31, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement backend sorting of users data for Facility -> Users table
2 participants