Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification for downloaded content completion #12295

Conversation

LianaHarris360
Copy link
Member

@LianaHarris360 LianaHarris360 commented Jun 17, 2024

Summary

This pull request involves the addition of a snackbar notification with the message “Download complete” to inform learners about resource download completion.

Once a resource is selected to be downloaded, a notification with the message “Download requested” and the option to “GO TO DOWNLOADS” appears. Now, on the remote content page, the learner is also notified when the download is finished.

topicsContent.mp4

References

Closes #10576

Reviewer guidance

Ensure that only after adding a new download and the content download is completed, the completed download snack-bar notification is displayed.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through code and it's looking good to me. Thank you @LianaHarris360

@LianaHarris360 LianaHarris360 merged commit 23e5fb8 into learningequality:develop Jun 18, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remote Content Browsing: Show download completed snackbar notification
2 participants