-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distributed error reporting: Endpoint /api/errorreports/report to store frontend error #12261
Merged
akolson
merged 8 commits into
learningequality:distributed-error-reporting
from
thesujai:distributed-error-reporting-task4
Jun 12, 2024
Merged
Distributed error reporting: Endpoint /api/errorreports/report to store frontend error #12261
akolson
merged 8 commits into
learningequality:distributed-error-reporting
from
thesujai:distributed-error-reporting-task4
Jun 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
DEV: backend
Python, databases, networking, filesystem...
SIZE: medium
labels
Jun 10, 2024
Build Artifacts
|
thesujai
force-pushed
the
distributed-error-reporting-task4
branch
from
June 12, 2024 09:49
6ee6c27
to
bb3dc75
Compare
thesujai
force-pushed
the
distributed-error-reporting-task4
branch
from
June 12, 2024 11:45
bb3dc75
to
09e2af3
Compare
akolson
reviewed
Jun 12, 2024
akolson
requested changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, LGTM. Just one comment and we should be good! Great work @thesujai
akolson
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @thesujai
akolson
merged commit Jun 12, 2024
53ae2ad
into
learningequality:distributed-error-reporting
10 checks passed
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References
Fixes #12259
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)