Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hitherto unnoticed regression in channel upgrade #12251

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Fix hitherto unnoticed regression in channel upgrade #12251

merged 1 commit into from
Jun 24, 2024

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jun 6, 2024 •
edited
Loading

Summary

  • The channel upgrade task passed an invalid kwarg to the channel upgrade management command
  • This caused the management command invocation to error after the upgrade to Django 3.2
  • Fixes this by not passing non-existent kwarg to management command.

References

Fixes unreported error which has now been noticed, so closes #12300

Reviewer guidance

Upgrade a channel to a newer version.
See that it works rather than breaks.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the P0 - critical Priority: Release blocker or regression label Jun 6, 2024
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: very small labels Jun 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Build Artifacts

Asset type Download link
PEX file kolibri-.pex
Windows Installer (EXE) kolibri-0.16.2a0.dev0+git.1208.ge02af196-windows-setup-unsigned.exe
Debian Package kolibri_0.16.2a0.dev0+git.1208.ge02af196-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.16.2a0.dev0+git.1208.ge02af196-0.4.2.dmg
Android Package (APK) kolibri-0.16.2a0.dev0+git.1208.ge02af196-0.1.3-debug.apk
TAR file kolibri-0.16.2a0.dev0+git.1208.ge02af196.tar.gz
WHL file kolibri-0.16.2a0.dev0+git.1208.ge02af196-py2.py3-none-any.whl

@pcenov pcenov self-requested a review June 21, 2024 11:46
pcenov
pcenov approved these changes Jun 21, 2024
View reviewed changes
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - no issues observed when testing the scenario described in #12300 and importing/upgrading a channel is working correctly now.

@marcellamaki marcellamaki merged commit 5cd1f6a into learningequality:develop Jun 24, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcenov pcenov pcenov approved these changes

@marcellamaki marcellamaki marcellamaki approved these changes

Assignees

@marcellamaki marcellamaki

Labels
DEV: backend Python, databases, networking, filesystem... P0 - critical Priority: Release blocker or regression SIZE: very small
Projects
None yet
Milestone
Kolibri 0.17: General maintenance, bu...
3 participants
@rtibbles @marcellamaki @pcenov