Fixing typo in useUser composable getter (again) #12235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtibbles
approved these changes
Jun 4, 2024
Build Artifacts
|
jasonmokk
pushed a commit
to jasonmokk/kolibri
that referenced
this pull request
Jun 17, 2024
jasonmokk
added a commit
to jasonmokk/kolibri
that referenced
this pull request
Jun 17, 2024
Remove from apispecs only Remove KTextTruncator from components [pre-commit.ci lite] apply automatic fixes Linting fixup minor fixup remove `resource_pool` from kolibri.core.exams useQuizCreation#saveQuiz: rm the resource_pool from sections before saving useQuizCreation#saveQuiz: mutate *copy* of section quiz file size displaying properly on the confirmation modal renaming modeQuiz Object variable Allow delete all questions [pre-commit.ci lite] apply automatic fixes Remove injection Update updateSection Bump the babel group with 4 updates Bumps the babel group with 4 updates: [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core), [@babel/plugin-syntax-import-assertions](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-syntax-import-assertions), [@babel/plugin-transform-runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-runtime) and [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env). Updates `@babel/core` from 7.24.5 to 7.24.6 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.24.6/packages/babel-core) Updates `@babel/plugin-syntax-import-assertions` from 7.24.1 to 7.24.6 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.24.6/packages/babel-plugin-syntax-import-assertions) Updates `@babel/plugin-transform-runtime` from 7.24.3 to 7.24.6 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.24.6/packages/babel-plugin-transform-runtime) Updates `@babel/preset-env` from 7.24.5 to 7.24.6 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.24.6/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: babel - dependency-name: "@babel/plugin-syntax-import-assertions" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: babel - dependency-name: "@babel/plugin-transform-runtime" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: babel - dependency-name: "@babel/preset-env" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: babel ... Signed-off-by: dependabot[bot] <[email protected]> Bump ini from 4.1.2 to 4.1.3 Bumps [ini](https://github.com/npm/ini) from 4.1.2 to 4.1.3. - [Release notes](https://github.com/npm/ini/releases) - [Changelog](https://github.com/npm/ini/blob/main/CHANGELOG.md) - [Commits](npm/ini@v4.1.2...v4.1.3) --- updated-dependencies: - dependency-name: ini dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Bump css-loader from 7.1.1 to 7.1.2 Bumps [css-loader](https://github.com/webpack-contrib/css-loader) from 7.1.1 to 7.1.2. - [Release notes](https://github.com/webpack-contrib/css-loader/releases) - [Changelog](https://github.com/webpack-contrib/css-loader/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/css-loader@v7.1.1...v7.1.2) --- updated-dependencies: - dependency-name: css-loader dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Bump video.js from 7.21.5 to 7.21.6 Bumps [video.js](https://github.com/videojs/video.js) from 7.21.5 to 7.21.6. - [Release notes](https://github.com/videojs/video.js/releases) - [Changelog](https://github.com/videojs/video.js/blob/v7.21.6/CHANGELOG.md) - [Commits](videojs/video.js@v7.21.5...v7.21.6) --- updated-dependencies: - dependency-name: video.js dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Bump ua-parser-js from 1.0.37 to 1.0.38 Bumps [ua-parser-js](https://github.com/faisalman/ua-parser-js) from 1.0.37 to 1.0.38. - [Release notes](https://github.com/faisalman/ua-parser-js/releases) - [Changelog](https://github.com/faisalman/ua-parser-js/blob/1.0.38/changelog.md) - [Commits](faisalman/ua-parser-js@1.0.37...1.0.38) --- updated-dependencies: - dependency-name: ua-parser-js dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Add full stop to full sentence. Bump vue2-teleport from 1.1.2 to 1.1.4 Bumps [vue2-teleport](https://github.com/Mechazawa/vue2-teleport) from 1.1.2 to 1.1.4. - [Commits](Mechazawa/vue2-teleport@v1.1.2...v1.1.4) --- updated-dependencies: - dependency-name: vue2-teleport dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> With 2.7 dropped, use shutil disk_usage function universally. Add not enough resources modal Fix message Fix message Fix bug not beign able to update resources ClosePanel on close no enough resources modal Add "add" to addMoreResourcesWithEmptyPool Fix replacements order fixing typo Added another condition for TOPICS_TOPIC_SEARCH redirection Also added every condition instead of some as I think this it is easier to read. Fixed linting Fixed expanded folder. Signed-off-by: wck-iipi <[email protected]> Fixed linting Fixing typo in useUser composable getter (again) (learningequality#12235) Handle case when username doesn't exist on remote and try to create it. Zip the whl file before uploading for BCK step. Update background image and background image display. Consolidate all theme images in default_theme plugin. Add transform to ensure proper layering in Safari. Bump recast from 0.23.7 to 0.23.9 Bumps [recast](https://github.com/benjamn/recast) from 0.23.7 to 0.23.9. - [Release notes](https://github.com/benjamn/recast/releases) - [Commits](benjamn/recast@v0.23.7...v0.23.9) --- updated-dependencies: - dependency-name: recast dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Clean up unused provide/injects for quiz management. Eliminate unused props driven parameterization of CoachAppBarPage and CoachImmersivePage permissions handling. Add new draft exam model to allow creation of exams as drafts, not ready to sync. Update exam API endpoint to handle draft exams. Remove cruft from serializers left over from when they weren't write only. Defer as many fields as possible to backend data handling. Update lesson API endpoints to have parallel assignments and active properties to exams. Update class summary API endpoint to reuse exam and lesson viewsets. Remove unneeded queries. Ensure object specs properly handle setting defaults on Array items. Update frontend for lesson.is_active to lesson.active. Update frontend to standardize use of 'assignments' for lesson. Update data helpers getters to work robustly from API derived lesson and quiz data. Remove use of 'this' and refer to 'getters' to avoid an implicit coupling with the commonCoach mixin. Small refactor of 'AssignmentDetailsModal' component (which is really a form) To simplify API and allow usage as an input component. Use AssignmentDetails component on create exam page to allow assignment in creation. Update quiz creation to allow editing as well. Replace all quiz editing with the component. Update section placeholder text to not be saved to backend. Fix unnoticed bug caused by missing string mixin. Update CoachExamsPage to use composables. Delete unused examsRoot vuex module. Fix exam copying. Remove unused examReport vuex module. Remove unneeded attributes from quiz object specs. Limit patch updates to only things we need/are allowed to update. Properly handle quiz activation from summary pages. Move NotEnoughResourcesModal to CreateQuizSection Remove empty sections when saving a syncable Exam. Move question_count setting to save method. Prevent publishing empty quizzes. Don't pop data model version to allow it to be accessed on the frontend. Warn users about the deletion of empty sections. Add missing full stop. Revert change that prevented search redirect in all cases. Fix bug by always closing the sidepanel on navigation. include item uid eqm strings updated update accordion* with useAccordion; update eqm components sections in core and learn exams updates for validations, section management attemptloglist conditionalize accordion on now-optional sections prop fix strings, bad early return in attemptloglist clear selected questions when moving between sections add save & close button to quiz creation;redirect accordingly practice quizzes don't have sections, reports work, hide accordion title if oly once seciont without a title don't remove replacementQuestionPool injection string updates post-review add currentSectionIndex to examViewer getters; displaysectiontitle update places where we used section_title but should use displaySectionTitle conditionalize cannot edit notice on quiz.draft add context around quiz edit warnings on start quiz update key for message to better represent the message Bump the babel group with 4 updates Bumps the babel group with 4 updates: [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core), [@babel/plugin-syntax-import-assertions](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-syntax-import-assertions), [@babel/plugin-transform-runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-runtime) and [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env). Updates `@babel/core` from 7.24.6 to 7.24.7 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.24.7/packages/babel-core) Updates `@babel/plugin-syntax-import-assertions` from 7.24.6 to 7.24.7 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.24.7/packages/babel-plugin-syntax-import-assertions) Updates `@babel/plugin-transform-runtime` from 7.24.6 to 7.24.7 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.24.7/packages/babel-plugin-transform-runtime) Updates `@babel/preset-env` from 7.24.6 to 7.24.7 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.24.7/packages/babel-preset-env) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: babel - dependency-name: "@babel/plugin-syntax-import-assertions" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: babel - dependency-name: "@babel/plugin-transform-runtime" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: babel - dependency-name: "@babel/preset-env" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: babel ... Signed-off-by: dependabot[bot] <[email protected]> Bump webpack from 5.91.0 to 5.92.0 Bumps [webpack](https://github.com/webpack/webpack) from 5.91.0 to 5.92.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.91.0...v5.92.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Use namespaced logging to ensure that messages are displayed. Remove unneeded logging statements. Bump braces from 3.0.2 to 3.0.3 Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Bump @testing-library/jest-dom from 6.4.5 to 6.4.6 Bumps [@testing-library/jest-dom](https://github.com/testing-library/jest-dom) from 6.4.5 to 6.4.6. - [Release notes](https://github.com/testing-library/jest-dom/releases) - [Changelog](https://github.com/testing-library/jest-dom/blob/main/CHANGELOG.md) - [Commits](testing-library/jest-dom@v6.4.5...v6.4.6) --- updated-dependencies: - dependency-name: "@testing-library/jest-dom" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Bump eslint-plugin-compat from 4.2.0 to 5.0.0 Bumps [eslint-plugin-compat](https://github.com/amilajack/eslint-plugin-compat) from 4.2.0 to 5.0.0. - [Release notes](https://github.com/amilajack/eslint-plugin-compat/releases) - [Changelog](https://github.com/amilajack/eslint-plugin-compat/blob/main/CHANGELOG.md) - [Commits](amilajack/eslint-plugin-compat@v4.2.0...v5.0.0) --- updated-dependencies: - dependency-name: eslint-plugin-compat dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> update exam.id when saving a new quiz, after replacing route do the update in saveQuiz be sure saveModel mock returns object to avoid failing test use outer scope `id` to be sure we're using originl val Use && instead of & for logical AND. Update to allow and implement randomization of sections. Default to fixed order. Ensure we save all relevant fields to the backend. Update global randomization flag display. Fix Quiz preview in reports. make resourceselection checkbox handle exercise case specially fix incorrect logic in hasCheckbox for topics unusedQuestionsCount & actuallyHasCheckbox -> setup(): fix missing checkboxes use actuallyHasCheckbox instead of hasCheckbox throughout resource selection trim the section_title in section editor dropme: we need to be sure that we use the displaySectionTitle overall this is reminder basically that we should always use displaySectionTitle -- could possibly be improved by making a computed activeSectionTitle computed property in usequizcreation? catch 'blank' error on quiz title and focus/scroll to invalid field add quizHasChanged bool, use to guard losing quiz changes better name for goingTo just scroll to top when title is invalid Update to 0.17 version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes a typo in the useUser composable. Renames
userIsMultipleFacilityAdmintouserIsMultiFacilityAdmin.Testing checklist
PR process
Reviewer checklist
yarnandpip)