-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manage users in LOD #12228
base: develop
Are you sure you want to change the base?
Manage users in LOD #12228
Conversation
Build Artifacts
|
0f51871
to
4c45c09
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some quick feedback - I've raised my main concern (which is more with the original spec, than the work you have done here) on Slack for further discussion, but ultimately I think having this as a separate SPA is not the right direction - but we'll see what the discussion leads us to.
@@ -210,6 +211,9 @@ export default { | |||
}, | |||
resources, | |||
themeConfig, | |||
machines: { | |||
importLodUsersMachine, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd rather put this in kolibri-common
rather than add it to the core API spec.
@@ -4,7 +4,7 @@ export default function UserType(userObject) { | |||
if (userObject.is_superuser) { | |||
return UserKinds.SUPERUSER; | |||
} | |||
if (!userObject.roles.length) { | |||
if (!userObject.roles || !userObject.roles.length) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to change but could also do:
if (!userObject?.roles.length) {
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining
(I feel like you used this in the useBaseSearch
refactor work)
Summary
lodOnly
prop on registerNavItem to register nav items just for LOD devices.core.auth.deleteimporteduser
endponit to remove a user in LOD devices along with its certificates and morango metadata.Screencasts
Compartir.pantalla.-.2024-06-26.18_35_32.mp4
Compartir.pantalla.-.2024-06-26.18_38_21.mp4
Compartir.pantalla.-.2024-06-26.18_33_36.mp4
References
Closes #12226
Reviewer guidance
Follow the specs.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)