Fix replacements order #12218
Merged
Fix replacements order #12218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Coach
Build Artifacts
|
nucleogenesis
approved these changes
May 30, 2024
Comment on lines
+170
to
+175
| const questions = activeQuestions.value.map(question => { | ||
| if (selectedActiveQuestions.value.includes(question.id)) { | ||
| return replacements.value.shift(); | ||
| } | ||
| return question; | ||
| }); |
There was a problem hiding this comment.
Love this mapping and shifting of the replacements list.
|
No issues observed while manually testing. Good to go! Thanks @AlexVelezLl |
radinamatic
approved these changes
May 31, 2024
There was a problem hiding this comment.
Manual QA passes, good to go! 💯 👏🏽 
Thank you @AlexVelezLl !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR maps the question replacements to the order in which the selected questions are.
References
Closes #12134.
Reviewer guidance
See $12134
Testing checklist
PR process
Reviewer checklist
yarnandpip)