Remove resource pool from exam serializer, don't send in API call #12200
Conversation
github-actions
bot
added
DEV: backend
| const resourcePoolAsIds = get(section).resource_pool.map(content => content.id); | ||
| section.resource_pool = resourcePoolAsIds; | ||
| const questionSourcesWithoutResourcePool = get(allSections).map(section => { | ||
| delete section.resource_pool; |
There was a problem hiding this comment.
It might be better to clone the object first:
const sectionToSave = {
...section,
};
delete sectionToSave.resource_pool;
return sectionToSave;
This will prevent unintended mutation of the composable state.
There was a problem hiding this comment.
(note, this applied to the previous code as well, it just only occurred to me now, as we are considering allowing editing after saving)
There was a problem hiding this comment.
Thanks for that - pushed an update
Build Artifacts
|
If it does, please add the reviewer guidance or a test case description, it's not immediately clear from the PR summary 😅 |
|
@rtibbles @radinamatic I think this is okay without any additional testing - I've successfully made and taken a quiz w/ these changes applied & tests pass so should be okay on passing code review |
Summary
The
resource_poolis not used when reading exam data back from the database and can be derived from the list of questions in each section by theirexercise_id.This removes it from the serializer and ensures it doesn't get send to the API when saving a quiz.