Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes progress indication bug #12185

Merged
merged 1 commit into from
May 22, 2024

Conversation

nathanaelg16
Copy link
Contributor

Summary

This change fixes the progress indication bug observed when one starts a lesson and returns to the class page without finishing. The bug occurs because polling for new lesson updates is only done after 30 seconds. This change makes it so that the app polls initially when the page is mounted, and then continues polling every 30 seconds thereafter.

BEFORE

Screenshot_20240518_094714

AFTER

Screenshot_20240518_094748

References

Reviewer guidance

  1. Log in as a learner
  2. Begin a new lesson (i.e. one that isn't already in progress)
  3. Open a resource, exit without completing it, and return to the class page
  4. The progress indicator should now show up for the lesson

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend SIZE: very small labels May 18, 2024
@MisRob MisRob requested review from akolson and AllanOXDi May 20, 2024 08:41
Copy link
Member

@akolson akolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Thanks @nathanaelg16!

@akolson
Copy link
Member

akolson commented May 20, 2024

Tagging @radinamatic @pcenov to have a look too!

@pcenov
Copy link
Member

pcenov commented May 20, 2024

Hi @akolson - no issues observed while manually testing, implemented as specified above. 👍

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA passes, good to go! 💯 👏🏽 :shipit:

Thank you, @nathanaelg16!

@rtibbles rtibbles merged commit c02140d into learningequality:develop May 22, 2024
31 checks passed
@nathanaelg16 nathanaelg16 deleted the issue_11879_fix branch May 29, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants