Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue where activeTabId is not set when viewing quiz reports for a group #12179

Merged

Conversation

nathanaelg16
Copy link
Contributor

Summary

This change appropriately sets the activeTabId to QuizzesTabs.REPORT so that the UI is rendered properly

Before
Screenshot_20240516_091235
Screenshot_20240516_091256

After
Screenshot_20240516_091528

  • No console errors produced

References

Reviewer guidance

To test these changes:

  1. Create a Quiz
  2. Create a Group
  3. Go to Coach > Reports > Groups > [group] > Reports > Quizzes assigned > [quiz] and try to select the "Report" tab
  4. Observe the changes fix the UI bug described in the issue, and console errors are cleared

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: very small labels May 16, 2024
@nucleogenesis nucleogenesis self-assigned this May 16, 2024
Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all LGTM! Thanks @nathanaelg16

@nucleogenesis nucleogenesis merged commit c47d734 into learningequality:develop May 21, 2024
31 checks passed
@nathanaelg16 nathanaelg16 deleted the issue_12132_fix branch May 25, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants