-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert ExamPage BottomAppBar to previous version (0.16.x) #12169
Revert ExamPage BottomAppBar to previous version (0.16.x) #12169
Conversation
Build Artifacts
|
Position of the buttons has been reverted to the previous state. Tested in Firefox and Chrome on Ubuntu 20.04: Mentioning again what we discussed recently, that currently is not possible to submit the quiz if there are unanswered questions, which I believe we concluded is an unwarranted limitation. I'm also wondering if the Try again string actually makes sense here at all... 🤔 Try again what? Should be straight Submit , no? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual QA passes, good to go! 💯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reverted code on the bottom bar looks fine, but let's also update the modal (sorry that this was not clear from our chat). Overall the entire workflow for the learner should be the same as it currently is in 0.16.
If we are able to update the workflow for 0.17.0 with Tomiwa's improved design, that's great, but I just want to make sure we don't end up with partial changes that could be more confusing.
Thanks @nucleogenesis ! Glad we're getting this sorted out
@marcellamaki @radinamatic I tested quizzes on the demo server and saw the "Try again" so I thought I was mimicking the 0.16 version but... turns out the demo server is still 0.15 😅 Just pushed an update to the message and handler for the modal -- now the user can click "Submit Quiz" in the modal to submit an unfinished exam. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine to me once QA team approves! 🎉
This looks fine to me once QA team approves! 🎉 - Marcella in a comment above & QA approved
Summary
In light of #12151 this PR reverses changes done in #11658 to the
BottomAppBar
inExamPage
.Updated:
Reviewer guidance
View the same quiz in 0.16 and this PR and see that the bottom app bar looks the same.