-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update facility settings link display for Learn Only Device users #12123
Update facility settings link display for Learn Only Device users #12123
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @LianaHarris360 , Looks good!
@radinamatic can you confirm the fix manually here, and then we can merge? |
Oh one thought here - as this doesn't involve any string updates, I think we could instead target this issue to the next 0.16 patch? |
4800313
to
c90e975
Compare
c90e975
to
763cb26
Compare
Thanks @LianaHarris360 - I confirm that this is implemented as specified above, no issues observed while manually testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual QA passes, good to go! 👏🏽 💯
f10889b
into
learningequality:release-v0.16.x
Summary
Previously admin users on a learn-only device could see "You can also configure Facility settings” link in Device settings, but users on a LOD cannot access the facility settings page. This pull request modifies the Device Settings page to display the link if the user is not on a Learn Only Device.
mapGetters
withisLearnerOnlyImport
on theDeviceSettingsPage
and modifies the conditional to display theKExternalLink
that leads toFacilityConfigPage
.View of a super admin on a full device:
Updated view for admins on a learn only device:
References
Closes #11877
Reviewer guidance
The changes you make here will affect this device only.
is displayed.The changes you make here will affect this device only. You can also configure device settings
are displayed.Testing checklist
PR process
Reviewer checklist
yarn
andpip
)