Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve webpack loaders and dependencies relative to kolibri-tools #12052

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

bjester
Copy link
Member

@bjester bjester commented Apr 4, 2024

Summary

Where you can find the dependencies for each of a project's dependencies depends on that project's package manager. With Studio using pnpm, the webpack config becomes relative to the Studio context, and Studio does not declare these dependencies, because it relies on kolibri-tools as a toolbox for all of them.

This PR updates the webpack config to use require.resolve on any Webpack loader or plugin that is passed by its string package name. It also updates kolibri-tools to import all node-specific dependencies using the node: protocol

References

Required by: learningequality/studio#4462

Reviewer guidance

Does anything break?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: tools Internal tooling for development SIZE: small labels Apr 4, 2024
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to go, and should make kolibri-tools more robust overall. We'll hold on merging until 0.16.1 has been released.

@rtibbles rtibbles self-assigned this Apr 9, 2024
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build still works fine!

@rtibbles rtibbles merged commit 421626f into learningequality:release-v0.16.x Apr 9, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: tools Internal tooling for development SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants