Added code for deletion of csv files in line #397 #12020
Conversation
github-actions
bot
added
DEV: backend
| @@ -392,6 +392,13 @@ def download_translations(branch, project, locale_data_folder): | |||
| code = lang_object[KEY_CROWDIN_CODE] | |||
| locale_dir_path = local_locale_path(lang_object, locale_data_folder) | |||
| logging.info("\tExtracting {} to {}".format(code, locale_dir_path)) | |||
|
|
|||
| #clear out existing files in langugage directory | |||
| for file_name in os.listdr(locale_dir_path): | |||
There was a problem hiding this comment.
I think this is probably meant to be os.listdir?
There was a problem hiding this comment.
Yes it is, apologies. Thanks for the correction.
| #clear out existing files in langugage directory | ||
| for file_name in os.listdr(locale_dir_path): | ||
| file_path = os.path.join(locale_dir_path, file_name) | ||
| if os.path.isfile(file_path): |
There was a problem hiding this comment.
As we are concerned only with CSV files here, we probably want to check that it is a CSV file before we delete it, just in case there are other files in this folder we don't want to delete!
Another way to do this would be to use the glob module instead of os.listdir, then you could just list out any existing CSV files and remove those: https://docs.python.org/3/library/glob.html#glob.glob
There was a problem hiding this comment.
Oh alright, I'd look into that thank you.
There was a problem hiding this comment.
I just made the respective change with glob, could you check it out? Thank you
| @@ -392,6 +393,11 @@ def download_translations(branch, project, locale_data_folder): | |||
| code = lang_object[KEY_CROWDIN_CODE] | |||
| locale_dir_path = local_locale_path(lang_object, locale_data_folder) | |||
| logging.info("\tExtracting {} to {}".format(code, locale_dir_path)) | |||
|
|
|||
| csv_files = glob.glob(os.path.join(locale_dir_path, '*.csv')) | |||
]
Outdated
| @@ -0,0 +1,5 @@ | |||
| Terminate batch job (Y/N)? | |||
There was a problem hiding this comment.
Hrm, I don't think we need any of the updates to any files apart from crowdin.py - could you remove this file, the package-lock.json, and the changes to package.json and yarn.lock?
There was a problem hiding this comment.
Okay yes I would and then I'd push. Thank you.
There was a problem hiding this comment.
Just did, could you confirm?
There was a problem hiding this comment.
Looks like there are still a couple of changes to package.json and yarn.lock.
You should be able to restore these to the default state on the develop branch if your develop branch is up to date with the upstream develop branch by doing this:
git checkout develop package.json yarn.lock
This will update the versions on your branch to the versions on develop - then commit the result so that there is no overall diff in this PR.
There was a problem hiding this comment.
Alright, I'd look into this. Thanks for the feedback.
There was a problem hiding this comment.
This should be done now. My sincere apologies, I had network issues.
github-actions
bot
added
DEV: renderers
rtibbles
removed
DEV: renderers
Build Artifacts
|
|
Thank you for your contribution @oge1ata! |
|
Thanks for your help and guidance as well @rtibbles. |
Summary
…
References
…
Reviewer guidance
…
Testing checklist
PR process
Reviewer checklist
yarnandpip)