Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version of all Android actions. #12007

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Update version of all Android actions. #12007

merged 1 commit into from
Mar 22, 2024

Conversation

rtibbles
Copy link
Member

Summary

  • Address progress int overflow issues
  • Address tasks getting cancelled after ten minutes
  • Ensure full compatibility with Android 14
  • Fix bug with release step

References

Fixes #11909

Reviewer guidance

As long as the APK builds fine, this should be good to merge. We'll get final confirmation of the fix for #11909 when we release again!

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Mar 21, 2024
@github-actions github-actions bot added DEV: dev-ops Continuous integration & deployment SIZE: very small labels Mar 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 21, 2024 •
edited
Loading

Build Artifacts

Asset type Download link
PEX file kolibri-0.16.1.dev0_git.20240321161759.pex
Windows Installer (EXE) kolibri-0.16.1.dev0+git.20240321161759-unsigned.exe
Debian Package kolibri_0.16.1.dev0+git.20240321161759-0ubuntu1_all.deb
Mac Installer (DMG) kolibri-0.16.1.dev0+git.20240321161759-0.4.0.dmg
Android Package (APK) kolibri-0.16.1.dev0+git.20240321161759-0.1.1-debug.apk
TAR file kolibri-0.16.1.dev0+git.20240321161759.tar.gz
WHL file kolibri-0.16.1.dev0+git.20240321161759-py2.py3-none-any.whl

marcellamaki
marcellamaki approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both files that reference learningequality/kolibri-installer-android have been updated

@rtibbles rtibbles merged commit 40373ad into learningequality:release-v0.16.x Mar 22, 2024
34 checks passed
@rtibbles rtibbles deleted the update_android branch March 22, 2024 20:39
@rtibbles rtibbles mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcellamaki marcellamaki marcellamaki approved these changes

Assignees
No one assigned
Labels
DEV: dev-ops Continuous integration & deployment SIZE: small SIZE: very small TODO: needs review Waiting for review
Projects
None yet
Milestone
Kolibri 0.16: Planned Patch 1
Development

Successfully merging this pull request may close these issues.
2 participants
@rtibbles @marcellamaki