-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Django to version 3.2 #11974
Update Django to version 3.2 #11974
Conversation
Build Artifacts
|
Ah, thanks @pcenov! Looks like none of the frontend files are being properly loaded - guessing Django is bypassing our previous setup somehow. |
Latest commit should have fixed this - updated assets will be along in a little while! |
Who knew that changing everything would be so difficult?! :) |
Looks like there's some more issues with how we parse arguments for the import channel command (and probably the import content command too). |
@pcenov this should now be fixed. I also looked for other possible instances of the same error. If you could also test the facility import, single user import + syncing, on my own setup + merge to single user syncing, and facility syncing that should cover the places that I updated. |
c169c58
to
eae1ecd
Compare
Hi @rtibbles, I found two additional issues while regression testing everything:
2024-03-13_17-56-28.mp4 |
Hi @pcenov - the android app kolibri log is exceptionally short. Could you rerun the app and grab the logcat output? That might give me some more clues. |
Some very interesting bugs in the other log, can take a closer look at them! |
Hi @rtibbles here's the logcat log: logcat.txt |
Thank you @pcenov - hah, I think this might be a result of our not having merged 0.16.x into develop recently enough rather than anything I've done here, so I'll get that sorted too. Thank you! |
Oh, on further investigation, that doesn't seem to be the issue - it just looks very similar to an error we had late on in the 0.16.0 release process. |
Hi @pcenov - I think I've addressed all the errors that I saw in the logs. |
7b5c745
to
06d39cc
Compare
Hi @rtibbles - I confirm that the Android app installs and runs correctly now. I'm still testing the critical workflows with all installers and will let you know if I find anything else that's not working. |
Hi @rtibbles the only new issues I was able to identify are for the Mac app. There I am getting a server error at Also no libraries are being displayed in the 'Other libraries' section of the Library page: |
as Django's anonymous user can no longer be an abstract model.
…t transaction to allow for bulk row insertion of self referential FKs, and optimized deletion.
Don't pass to non-resume command.
…ors during introspection.
Add dummy get_queryset and get_serializer_class methods otherwise.
Summary
header
attribute for response objects to access header values__all__
None
as a value for a POST - the Django test client no longer allows thisis_authenticated
check from method invocation to property check--all
argument to the makemessages commanddistinct
called on themReferences
Fixes #11726
Reviewer guidance
The urls migration could have been done more selectively by using
path
instead ofre_path
in cases where regex is not strictly needed, but that seemed like a task better suited for follow up.The database attribute of test classes could also have been more selectively applied, but it was easier to use
__all__
.Do tests pass?
I didn't update any documentation, as I don't think anything hugely changed.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)