Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev docs typo #11878

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Fix dev docs typo #11878

merged 1 commit into from
Feb 15, 2024

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Feb 15, 2024

Summary

Fixes a tiny typo in the documentation for new strings syntax (discovered here).

Screenshot from 2024-02-15 13-46-15

I think the intention was rather:

const { myCoolString$, stringWithArgument$ } = commonStringsModule;

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob MisRob added the TODO: needs review Waiting for review label Feb 15, 2024
@MisRob MisRob requested a review from rtibbles February 15, 2024 12:50
@MisRob MisRob added the TAG: developer docs Technical docs and code comments label Feb 15, 2024
@rtibbles rtibbles merged commit 5e7942d into learningequality:develop Feb 15, 2024
31 checks passed
@MisRob MisRob deleted the dev-docs branch February 29, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SIZE: very small TAG: developer docs Technical docs and code comments TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants