Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate long lesson title #11874

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

nikkuAg
Copy link
Contributor

@nikkuAg nikkuAg commented Feb 14, 2024

Summary

I have added the TextTruncateCss component from the design library to truncate the lesson title that were overlapping with other text.
image

References

Issue: #7579

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: very small labels Feb 14, 2024
@MisRob MisRob self-assigned this Feb 15, 2024
@MisRob MisRob self-requested a review February 15, 2024 11:25
@MisRob MisRob added the TODO: needs review Waiting for review label Feb 15, 2024
@pcenov pcenov self-requested a review February 15, 2024 12:05
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues observed while manually testing - implemented as specified above and longer text is being truncated now.

Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code's fine. Thanks @nikkuAg and @pcenov.

@MisRob
Copy link
Member

MisRob commented Feb 15, 2024

Docs failure is not related to this PR and should be fixed on develop

@MisRob MisRob merged commit 4c42642 into learningequality:develop Feb 15, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend SIZE: very small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants