Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that Kolibri can start regardless of whether redis and redis cache is installed. #11868

Merged

Conversation

rtibbles
Copy link
Member

Summary

Reviewer guidance

Easiest way to test this is from source, install all requirements, then do:
pip uninstall redis
Ensure that Kolibri still starts.
pip install redis
pip uninstall django-redis-cache
Ensure that Kolibri still starts.

Finally reinstall both packages, and set the following settings in options.ini:

[Cache]
CACHE_BACKEND = redis
CACHE_REDIS_MAXMEMORY_POLICY = allkeys-lru
CACHE_REDIS_MAXMEMORY = 1660575744

Make sure you have Redis setup locally, and ensure that Kolibri still starts properly.

Finally, install the APK and ensure that it now starts properly.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: small labels Feb 13, 2024
Copy link
Member

@jredrejo jredrejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looked good, but a minor change is needed for it to work

kolibri/core/utils/cache.py Outdated Show resolved Hide resolved
@radinamatic
Copy link
Member

APK is a go, no errors on my Motorola GPlay51!!! 🚀 🎉

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go on physical Android device! 💯 :shipit:

@rtibbles rtibbles merged commit 2837e15 into learningequality:release-v0.16.x Feb 13, 2024
34 checks passed
@rtibbles rtibbles deleted the no_redis_cache_no_problem branch February 13, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants