Standardize ContentCardList Component and Introduce ViewMoreButtonStates #11865
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11771
Summary
In the process of content creation, we drew inspiration from previous Lesson resource selection components, specifically the ContentCardList component. However, considering the component's last update was three years ago, there are noticeable inconsistencies that we aim to address for a more unified developer interface.
The
viewMoreButtonState
prop in the ContentCardList component currently relies on a string input. To enhance consistency and maintainability, we propose the transition to a constant-based approach.Acceptance Criteria:
View More Button State
ViewMoreButtonStates
in thecoach/.../constants/index.js
file, structured similarly to existing constants.viewMoreButtonStates
prop against these constants, ensuring only valid constants are accepted.ViewMoreButtonStates.hasMore
state.These changes aim to standardize the ContentCardList component and introduce a clear set of constants for the viewMoreButtonState prop. This not only improves code consistency but also facilitates easier maintenance and future development.
…
References
…
Reviewer guidance
…
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)