-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No download buttons in app context #11740
Merged
rtibbles
merged 3 commits into
learningequality:release-v0.16.x
from
rtibbles:no_download_buttons_in_app_context
Jan 18, 2024
Merged
No download buttons in app context #11740
rtibbles
merged 3 commits into
learningequality:release-v0.16.x
from
rtibbles:no_download_buttons_in_app_context
Jan 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Device
Re: Device App (content import/export, facility-syncing, user permissions, etc.)
APP: Facility
Re: Facility App (user/class management, facility settings, csv import/export, etc.)
APP: Coach
Re: Coach App (lessons, quizzes, groups, reports, etc.)
DEV: frontend
SIZE: small
labels
Jan 17, 2024
Build Artifacts
|
pcenov
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confirm that the download option is removed in the app.
radinamatic
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual QA passed, good to go! 👍🏽 💯
marcellamaki
approved these changes
Jan 18, 2024
Docs build fixed on release. |
rtibbles
merged commit Jan 18, 2024
cde93f0
into
learningequality:release-v0.16.x
33 of 34 checks passed
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
APP: Coach
Re: Coach App (lessons, quizzes, groups, reports, etc.)
APP: Device
Re: Device App (content import/export, facility-syncing, user permissions, etc.)
APP: Facility
Re: Facility App (user/class management, facility settings, csv import/export, etc.)
DEV: frontend
SIZE: small
TODO: needs review
Waiting for review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reviewer guidance
Run the app devserver using the standard guidance
Navigate to a resource
Open the browse metadata side panel
Ensure that no download button appears
QA Guidance:
Run the Android App
Import a single resource
Navigate to resource in Learn
Open the browse metadata side panel
Ensure that no download button appears
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)