Fix to Env Var and Config persisting in options.ini in KOLIBRI_HOME

[thesujai]

Summary

This Solution Aims to override the default config of environment variables in _set_from_envvars
…

References

Fixes #9551
…

Reviewer guidance

…

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[thesujai]

Hello @rtibbles, please also have a look at 556de59, this way the DEBUG and other env variables that are generated persist(ephemeral configuration), but they are set to FALSE

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0b10.dev0_git.139.g4b5fe9fe.pex
Windows Installer (EXE)	kolibri-0.16.0b10.dev0+git.139.g4b5fe9fe-unsigned.exe
Debian Package	kolibri_0.16.0b10.dev0+git.139.g4b5fe9fe-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0b10.dev0+git.139.g4b5fe9fe-0.3.0.dmg
Android Package (APK)	kolibri-0.16.0b10.dev0+git.139.g4b5fe9fe-0.1.0-debug.apk
TAR file	kolibri-0.16.0b10.dev0+git.139.g4b5fe9fe.tar.gz
WHL file	kolibri-0.16.0b10.dev0+git.139.g4b5fe9fe-py2.py3-none-any.whl

[rtibbles]

This breaks existing functionality, even if it does fix the issue.

[thesujai]

@rtibbles I made a change directly in the generate_empty_options_file so i dont think it will break any functionality, as it is supposed to run only in initialization process, that too only when the options.ini not already exists (https://github.com/learningequality/kolibri/blob/release-v0.16.x/kolibri/utils/sanity_checks.py#L138)

So ig this should not break any functionality and still solve the issue

[rtibbles]

Excellent! This does exactly what we need, with a very small diff. Code looks good, and manual testing checks out.

[rtibbles]

Docs build failure is fixed on the release branch, merging.