Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate browser compatibility data, drop IE11 support #11685

Merged
merged 4 commits into from
Jan 11, 2024

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jan 2, 2024

Summary

  • Consolidates browser compatibility data so that we use the same source of truth for browserslist and checking supported browsers in the frontend
  • Drops IE11 support
  • Updates deprecation warnings about IE11 for browsing users to give upgrade warning instead

References

Fixes #5336

Reviewer guidance

The only other place I could find IE11 specific code was in the TextTruncatorCSS component, but I was not entirely sure how to remove the IE11 specific code. Advice from @MisRob would be appreciated, or we can file a follow up issue for this cleanup.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Jan 2, 2024
@rtibbles rtibbles requested a review from marcellamaki January 2, 2024 22:53
@github-actions github-actions bot added APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) DEV: frontend DEV: tools Internal tooling for development SIZE: small labels Jan 2, 2024
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem okay, but the browser requirements code is hard to follow. Added a comment about what in particular tripped me up, but happy to chat further about what might help

@rtibbles
Copy link
Member Author

Have updated to try to make the parsing logic more self explanatory.

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for breaking this down - I find it much easier to comprehend. Per slack discussion, we'll go forward with this and check in with @MisRob re: TextTruncator and address in a follow up issue as appropriate

@rtibbles
Copy link
Member Author

Follow up will happen in KDS where KTextTruncator has been implemented.

@rtibbles
Copy link
Member Author

Docs build failure is unrelated, merging.

@rtibbles rtibbles merged commit bab585a into learningequality:develop Jan 11, 2024
30 of 31 checks passed
@rtibbles rtibbles deleted the ie11_we_hardly_knew_ye branch January 11, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) DEV: frontend DEV: tools Internal tooling for development SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants