-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to new badge being shown on channel delete #11676
Fix to new badge being shown on channel delete #11676
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look fine - @pcenov could you verify the fix? It seems that the key to replication is to have imported some resources, and then to have deleted a resource without having cleared the import task.
@thesujai this is great, could you retarget to release-v0.16.x and rebase to that branch too? We can release this in a patch release to 0.16. |
7b94dda
to
7941f44
Compare
Hey @rtibbles 👋🏽 |
Thanks @thesujai - looks like this is ready to go. We'll hold off merging until 0.16.0 has been released, but no more work needs to be done here! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we changed our minds, and this is safe enough to merge for 0.16.0, thank you for your contribution!
Summary
The cause of the bug is well addressed in #6730 (comment)
For handling that we will show
new
badge based on the latest task which will be the task with highest scheduled_datetime(among the tasks with same channel_id)Screencast
Here I delete resource initially(shows no
new
badge)Then install more resource(shows
new
badge as it should)Then remove a resource(shows no
new
badge, as it shouldn't)Screencast from 28-12-23 04:11:18 PM IST.webm
…
References
Fixes #6730
…
Reviewer guidance
…
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)