Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve the out of frame bug of quiz images #11568

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

nikkuAg
Copy link
Contributor

@nikkuAg nikkuAg commented Nov 29, 2023

Summary

The dynamic sizing of images was causing overflow issues as it relied on the 'width' attribute, leading to images getting out of frame.

before_SqGbiqV9.mp4

I addressed this by updating the code to use the 'min-width' attribute, ensuring the image size adapts dynamically while preventing overflow. This resolves the framing issues.

after_B8cgtCAj.mp4

References

#9211

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob MisRob added the TODO: needs review Waiting for review label Nov 30, 2023
@MisRob MisRob requested review from radinamatic and pcenov November 30, 2023 08:17
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nikkuAg - I confirm that the underlying issue is fixed now.

@MisRob
Copy link
Member

MisRob commented Dec 7, 2023

Thanks @nikkuAg, we will review

Copy link
Contributor

@thanksameeelian thanksameeelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change looks good to me. thank you for your work fixing this, @nikkuAg!

@MisRob MisRob merged commit 126340b into learningequality:release-v0.16.x Dec 11, 2023
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants