-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify our slack on contributors' issue comments #11564
Conversation
Build Artifacts
|
run: | | ||
curl -X POST -H 'Content-type: application/json' \ | ||
--data \ | ||
'{"text": "New comment on issue: '${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/issues/${{ github.event.issue.number }}' by '${GITHUB_ACTOR}'"}' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible tweaks here:
- Put the issue name instead of just 'issue'
- Make a link out of the issue name
- Update the link to include the reference to the specific comment so that clicking on it will open the issue at that specific comment
- Could also make the github actor text link to the user profile of the github user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've included the issue title and linked it to the specific comment. I have not added github profile user link because that would be unnecessary.
@rtibbles marked this ready to merge. 🎉 Here's the link to the slack app that I added -- https://api.slack.com/apps/A067L07B9QW/incoming-webhooks. We need to add a webhook to that app, some instructions here on that -- https://api.slack.com/messaging/webhooks and we also need to add that webhook as a github secret. |
Great, let's give it a try then? @rtibbles do you think you could help with setting Slack webhooks, please? We've tried earlier with @marcellamaki but neither of us has permissions. |
Was there a reason not to use the offiicial Slack github action here? https://github.com/slackapi/slack-github-action |
Readthedocs build seems to have stalled, merging anyway. |
No reason as such I guess, but I agree it would be better to use their official action, will fix it. |
Summary
This adds a github action that will notify our slack #dev-community channel when any contributor comments on a issue.
ToDo --
SLACK_WEBHOOK_URL
as a GitHub secret.References
Closes #9521.
Reviewer guidance
I don't know how best to test this 🤷♂️
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)