Don't display LOD sync or cleanup sync tasks on the Facility Tasks page

[marcellamaki]

Summary

Adds a condition so that LOD sync tasks and related cleanup sync tasks are not displayed on the facility task management page. Display all of these tasks here would potentially overwhelm the user and provide information that is not useful to facility syncs specifically

References

Fixes #11543

Before	After

Reviewer guidance

In a LOD scenario, navigate to the facility task page. Perform different tasks such as importing a facility, as well as some LOD syncing. With this update, the facility import task should display, for example, but "blank" tasks related to LOD or cleanup syncs should not display.

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[bjester]

This seems like an acceptable change. I've now realized the reason for the cleanupsync task appearing is because it's in the facility_task_queue. So alternatively, we could remove it from that queue and it shouldn't appear anymore. Although, as the queue is used to group tasks, it does make sense to exist in that queue. 🤷

So that said, LGTM

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0b8.dev0_git.52.g535e0bb0.pex
Windows Installer (EXE)	kolibri-0.16.0b8.dev0+git.52.g535e0bb0-unsigned.exe
Debian Package	kolibri_0.16.0b8.dev0+git.52.g535e0bb0-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0b8.dev0+git.52.g535e0bb0-0.3.0.dmg
Android Package (APK)	kolibri-0.16.0b8.dev0+git.52.g535e0bb0-0.1.0-debug.apk
TAR file	kolibri-0.16.0b8.dev0+git.52.g535e0bb0.tar.gz
WHL file	kolibri-0.16.0b8.dev0+git.52.g535e0bb0-py2.py3-none-any.whl

[bjester]

On second thought (shared more on Slack), I think we should remove the queue from the task instead. That will stop the cleanupsync task from being returned by the API, and prevent the API response from being bloated by these hidden tasks. The LOD tasks are already in a different queue. My bad for forgetting how the queue was utilized for this in the first place!

[radinamatic]

LoD syncs may have been removed correctly from the task list , but they still appear in the counter on the Device - Facilities page:

sync-facilities.mp4

[bjester]

LoD syncs may have been removed correctly from the task list , but they still appear in the counter on the Device - Facilities page:

Removing the queue will also resolve this.

[bjester]

I guess I approve these changes 😄

[marcellamaki]

I also approve it 😄