Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle weird edge case where the extra_settings key does not exist yet. #11545

Merged
merged 1 commit into from
Nov 20, 2023
+4 −1
Merged

Handle weird edge case where the extra_settings key does not exist yet. #11545

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion kolibri/core/device/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,10 @@ def _get_extra(self, name):
:param name: A str name of the `extra_settings` field
:return: mixed
"""
return self.extra_settings.get(name, extra_settings_default_values[name])
try:
return self.extra_settings.get(name, extra_settings_default_values[name])
except KeyError:
return extra_settings_default_values[name]

@property
def allow_download_on_metered_connection(self):
Expand Down