Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep current back link when navigating through the topics folder side panel #11435

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Oct 20, 2023

Summary

  • Fixes error in link generation in folder side navigation panel and ensures that the current back link is preserved during navigation - to be identical to clicking on a folder card in the main navigation panel

References

Fixes #11432

Reviewer guidance

Click on a folder in the left side panel.
Press the X to close out the immersive modal, ensure that it does close.

Do the same when exploring a remote library and ensure navigation occurs correctly.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Oct 20, 2023
@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: very small labels Oct 20, 2023
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code change makes sense to me - seems like the better function to use (and luckily past Richard already did the hard part of making it!). I'll let @radinamatic confirm that it's covering all of the scenarios she reported.

@radinamatic
Copy link
Member

Not yet, apparently... I tested the DEB asset in both Chrome & Firefox on Ubuntu, and the issue persists 🤔

backlink.mp4

Only one error noted in the Chrome console, not sure if it's relevant.

2023-10-20_19-56-30

Add backlink utility for adding the previous back link.
Use it in for Folder links from the TopicsContentPage.
@rtibbles
Copy link
Member Author

This scenario should now also be covered!

@pcenov pcenov self-requested a review October 23, 2023 11:29
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine now!

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA confirms the fix, good to go! 💯 🎉 :shipit:

Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional code changes look good to me. The renaming for folder variable is also helpful - thanks!

@marcellamaki marcellamaki merged commit 0f98b53 into learningequality:release-v0.16.x Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: small SIZE: very small TODO: needs review Waiting for review
Projects
None yet
4 participants