-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep current back link when navigating through the topics folder side panel #11435
Keep current back link when navigating through the topics folder side panel #11435
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code change makes sense to me - seems like the better function to use (and luckily past Richard already did the hard part of making it!). I'll let @radinamatic confirm that it's covering all of the scenarios she reported.
Add backlink utility for adding the previous back link. Use it in for Folder links from the TopicsContentPage.
This scenario should now also be covered! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual QA confirms the fix, good to go! 💯 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional code changes look good to me. The renaming for folder variable is also helpful - thanks!
Summary
References
Fixes #11432
Reviewer guidance
Click on a folder in the left side panel.
Press the X to close out the immersive modal, ensure that it does close.
Do the same when exploring a remote library and ensure navigation occurs correctly.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)