Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added python 3.12 to setup.py #11420

Closed
wants to merge 1 commit into from
Closed

Conversation

im-NL
Copy link
Contributor

@im-NL im-NL commented Oct 16, 2023

Summary

  • Added python 3.12 as a valid version of python in setup.py
  • pip install -e . working only after added python 3.12 to setup.py

References

#11316 task 1


Testing checklist

  • Contributor has fully tested the PR manually

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: very small labels Oct 16, 2023
@rtibbles
Copy link
Member

This one can't really be merged independently of the other tasks - as it is asserting that Kolibri is compatible with Python 3.12 - so ideally we'd make the other changes to add tests etc. in this PR as well.

@rtibbles
Copy link
Member

I am going to close this as it has been inactive for a while, and no updates have been made to resolve the required changes.

@rtibbles rtibbles closed this Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants