-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated base.dockerfile for all architectures #11408
Updated base.dockerfile for all architectures #11408
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for opening a PR!
I proposed one change to update the base image to a newer version of ubuntu, which might make some other changes unnecessary
dpkg -i ./nodejs_$NODE_VERSION-1nodesource1_amd64.deb && \ | ||
rm nodejs_$NODE_VERSION-1nodesource1_amd64.deb && \ | ||
ARCH=$(dpkg --print-architecture) && \ | ||
curl -sSO https://deb.nodesource.com/node_16.x/pool/main/n/nodejs/nodejs_$NODE_VERSION-1nodesource1_$ARCH.deb && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a couple more related changes that helped make docker-demoserver
a bit, but overall your changes bring it more up-to-date. Nice work! Thank you!
Build Artifacts
|
Summary
References
Discussions #11353
Reviewer guidance
is it possible to add hacktoberfest-accepted label in this PR ?
Go to the kolibri directory
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)