Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated base.dockerfile for all architectures #11408

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

a6ar55
Copy link
Contributor

@a6ar55 a6ar55 commented Oct 13, 2023

Summary

  • Modified installation of nodejs,node packages for all architectures.
  • Modified python version to python3 to deal with compatibility issue of sqlalchemy 1.4.49 with python 2.7.18
Screenshot 2023-10-10 at 6 14 02 PM
  • Added symbolic links to make sure that the commands "python" and "pip" point to the appropriate Python 3 versions.
  • Exported environment variable. [ ENV LC_ALL C.UTF-8 , ENV LANG C.UTF-8 ] to set the locale to C.UTF-8
Screenshot 2023-10-13 at 6 11 44 PM

References

Discussions #11353

Reviewer guidance

is it possible to add hacktoberfest-accepted label in this PR ?
Go to the kolibri directory

  • make docker-build-base
  • make docker-devserver

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob MisRob added the TODO: needs review Waiting for review label Oct 16, 2023
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening a PR!

I proposed one change to update the base image to a newer version of ubuntu, which might make some other changes unnecessary

docker/base.dockerfile Outdated Show resolved Hide resolved
dpkg -i ./nodejs_$NODE_VERSION-1nodesource1_amd64.deb && \
rm nodejs_$NODE_VERSION-1nodesource1_amd64.deb && \
ARCH=$(dpkg --print-architecture) && \
curl -sSO https://deb.nodesource.com/node_16.x/pool/main/n/nodejs/nodejs_$NODE_VERSION-1nodesource1_$ARCH.deb && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@github-actions github-actions bot added the DEV: backend Python, databases, networking, filesystem... label Oct 16, 2023
@bjester bjester self-requested a review October 16, 2023 21:47
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a couple more related changes that helped make docker-demoserver a bit, but overall your changes bring it more up-to-date. Nice work! Thank you!

@bjester bjester added the hacktoberfest-accepted A label to apply to PRs that have been merged and can be used for participation in hacktoberfest label Oct 16, 2023
@bjester bjester merged commit 845d001 into learningequality:release-v0.16.x Oct 16, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... hacktoberfest-accepted A label to apply to PRs that have been merged and can be used for participation in hacktoberfest SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants