Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding padding in ViewMore button #11398

Merged

Conversation

thesujai
Copy link
Contributor

Summary

Just added padding in bottom of div class inclosing button View More
..

Screenshot
Screenshot from 2023-10-13 00-52-12

...

References

This PR fixes #11387

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: very small labels Oct 12, 2023
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes make sense - quick verification that the issue is fixed would be appreciated, @pcenov!

@rtibbles rtibbles added the hacktoberfest-accepted A label to apply to PRs that have been merged and can be used for participation in hacktoberfest label Oct 12, 2023
@pcenov pcenov self-requested a review October 13, 2023 06:28
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing checks out!

@rtibbles rtibbles merged commit 6d9ce4c into learningequality:release-v0.16.x Oct 18, 2023
AllanOXDi pushed a commit to AllanOXDi/kolibri that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) hacktoberfest-accepted A label to apply to PRs that have been merged and can be used for participation in hacktoberfest SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more padding below the 'View More' button to enhance its visibility
2 participants