Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace KResponseWiindow with useKResponseWindow in Epub Viewer plugin #11369

Conversation

thesujai
Copy link
Contributor

@thesujai thesujai commented Oct 8, 2023

Summary

For testing:

  1. First Identified where ResponsiveWindow elements are are used
  2. Then play with CSS class of components that will be used when windowBreakpoint is reached.
  3. Then verify that the CSS tweaks is consistent with both KResponsiveWindow and userKResponsiveWindow
  4. Roll back the CSS tweaks made while testing

Page Affected

The e pub viewer is affected

References

This PR fixes #11326

Reviewer guidance

Would it be possible to add a hacktoberfest-accepted label in this PR?
Here is the link: https://hacktoberfest.com/participation/#maintainers
Its fine if for some reasons you aren't able to do so:)


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All code changes correct.

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll do any additional QA in general regression testing, this is very low risk.

@rtibbles rtibbles added the hacktoberfest-accepted A label to apply to PRs that have been merged and can be used for participation in hacktoberfest label Oct 11, 2023
@rtibbles rtibbles merged commit 16a9422 into learningequality:develop Oct 11, 2023
34 checks passed
@thesujai
Copy link
Contributor Author

Thank You @rtibbles, it was nice working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted A label to apply to PRs that have been merged and can be used for participation in hacktoberfest SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants