Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lesson visibility toggling for single user syncing #11359

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Oct 5, 2023

Summary

  • Updates morango to prevent merge conflicts arising when deleted models are recreated
  • Adds morango ecosystem tests to ensure that object recreation propagates, and that deletion propagation is still working as intended

References

Fixes #11208

Reviewer guidance

  • Setup a learner only device from a server device
  • On the server device toggle a lesson to be visible
  • Let the sync to the learner only device happen
  • Toggle the lesson to be invisible
  • Let the sync to the learner only device happen
  • Toggle the lesson to be visible again
  • Let the sync to the learner only device happen

After each sync confirm the lesson is correctly displayed or not on the learner only device.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles added the TODO: needs review Waiting for review label Oct 5, 2023
@rtibbles rtibbles requested review from jamalex, bjester and pcenov October 5, 2023 21:40
@github-actions github-actions bot added DEV: backend Python, databases, networking, filesystem... SIZE: small labels Oct 5, 2023
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rtibbles, no issues observed with enabling/disabling the assigned lessons to a learner on a LOD.
Attaching the logs of the learn only device and the server in case you are able to spot anything wrong there:

LOD_logs.zip

Server_logs.zip

Copy link
Member

@jamalex jamalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank youuuu!

@rtibbles rtibbles merged commit a5992fb into learningequality:release-v0.16.x Oct 7, 2023
@rtibbles rtibbles deleted the now_you_see_it_now_you_dont branch October 7, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Learn-only device syncing: lesson doesn't re-appear on learner device after reactivating it on server
3 participants