-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak provisioning interaction with OS User capability #11352
Tweak provisioning interaction with OS User capability #11352
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updates in serializers
are great and straightforward.
I have one question/suggestion regarding the changes to the wizardMachine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM! Will leave final approval to @pcenov after manual testing
Hi @rtibbles, I confirm that the points listed above are working as described. I just have the following note: After closing and relaunching the app I am always signed in as the super admin user regardless of the fact that there are other users on the device. This is especially confusing if I have been signed in as any of the other users prior to closing the app. Shouldn't this rule for automatically signing in the user be applied only if that is the only user on the device? Admin.is.always.signed.in.mp4 |
@pcenov I have opened a follow up issue for what you are describing here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
Summary
References
No extant issue, noticed in the course of fixing #133
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)