Bugfix- birth year selction on profile edit page

[haldaranup]

Summary

After selecting birth year the value gets mismatched because of incorrect label. This is because of timezone, when localized in any timezone that is less than UTC, ex- new Date('2023') the date will be shown 2022 instead of 2023

So, instead of passing year directly to $fomatDate('2023'), setting full year to it so there is no effect of timezone

…

References

Fixes #11292

…

Reviewer guidance

• Go to profile edit page
• Try to change the birth year
• After saving check if the year is showing correctly

…

---

Testing checklist

• Contributor has fully tested the PR manually
• If there are any front-end changes, before/after screenshots are included
• Critical user journeys are covered by Gherkin stories
• Critical and brittle code paths are covered by unit tests

PR process

• PR has the correct target branch and milestone
• PR has 'needs review' or 'work-in-progress' label
• If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
• If this is an important user-facing change, PR or related issue has a 'changelog' label
• If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

• Automated test coverage is satisfactory
• PR is fully functional
• PR has been tested for accessibility regressions
• External dependency files were updated if necessary (yarn and pip)
• Documentation is updated
• Contributor is in AUTHORS.md

[rtibbles]

Hi @haldaranup - thanks, this definitely looks like the right fix!

I think we would like to include this in our upcoming release, so if I could ask you to rebase this PR onto release-v0.16.x that would be great.

To do this, I would suggest the following workflow:

• Make sure you have local versions of the Learning Equality develop branch and the Learning Equality release-v0.16.x branch and that they are both up to date - for the sake of the following, I will assume they are called develop and release-v0.16.x respectively.
• Locally, checkout your feature branch
• Run this rebase command: git rebase --onto release-v0.16.x develop this will rebase your current branch (your feature branch) onto release-v0.16.x, removing any commits that are already present in develop - so, if everything works as expected, it should keep your commit bugfix- birth year selction
• Once you have done that, you will need to force push to update your remote branch git push --force - if the remote branch is not set, then git should give you hints about how to push to the correct remote branch.

[haldaranup]

Hi @haldaranup - thanks, this definitely looks like the right fix!

I think we would like to include this in our upcoming release, so if I could ask you to rebase this PR onto release-v0.16.x that would be great.

To do this, I would suggest the following workflow:

• Make sure you have local versions of the Learning Equality develop branch and the Learning Equality release-v0.16.x branch and that they are both up to date - for the sake of the following, I will assume they are called develop and release-v0.16.x respectively.
• Locally, checkout your feature branch
• Run this rebase command: git rebase --onto release-v0.16.x develop this will rebase your current branch (your feature branch) onto release-v0.16.x, removing any commits that are already present in develop - so, if everything works as expected, it should keep your commit bugfix- birth year selction
• Once you have done that, you will need to force push to update your remote branch git push --force - if the remote branch is not set, then git should give you hints about how to push to the correct remote branch.

Thanks @rtibbles, I have done the steps mentioned above. Please let me know if any other changes are required or if anything is done incorrectly

[rtibbles]

Looks right to me, thank you! We will do a full review on Monday.

[github-actions]

Build Artifacts

Asset type	Download link
PEX file	kolibri-0.16.0b6.dev0_git.39.gcea479d7.pex
Windows Installer (EXE)	kolibri-0.16.0b6.dev0+git.39.gcea479d7-unsigned.exe
Debian Package	kolibri_0.16.0b6.dev0+git.39.gcea479d7-0ubuntu1_all.deb
Mac Installer (DMG)	kolibri-0.16.0b6.dev0+git.39.gcea479d7-0.3.0.dmg
Android Package (APK)	kolibri-0.16.0b6.dev0+git.39.gcea479d7-0.1.0-debug.apk
TAR file	kolibri-0.16.0b6.dev0+git.39.gcea479d7.tar.gz
WHL file	kolibri-0.16.0b6.dev0+git.39.gcea479d7-py2.py3-none-any.whl

[rtibbles]

Code looks good and manual testing checks out - the value of the component and the label match! Could you fix the line length for your comments, so we can merge?

[pcenov]

LGTM as well, no issues observed while manually testing.

[rtibbles]

Thank you for your contribution @haldaranup!