Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump @shopify/draggable from 1.0.0-beta.8 to 1.0.0 #11293

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 25, 2023

Bumps @shopify/draggable from 1.0.0-beta.8 to 1.0.0.

Release notes

Sourced from @​shopify/draggable's releases.

v1.0.0-beta.12

Added

  • Added drag:stopped event that will be fired after drag finished
  • Support specifying an array of class name to Draggable classes option

Changed

  • Fixes incorrect oldIndex value when working with nested sortable
  • Fixes wrong same container checking bug when working with nested sortable
  • Fixes bug drag:start event was triggered during the delay time
  • Fixes missing overContainer property in DragOutEvent

v1.0.0-beta.11

Added

  • Added exclude option to allow disable default plugins and sensors
  • Added missing plugin types
  • Support set the type of callback function according to the event type

Changed

  • Fixes drag start concurrency (delay and distance options)
  • Fixes text in mirror blurry
  • Fixes accidentally append mirror

v1.0.0-beta.10

Added

  • Added SortAnimation plugin
  • Added distance?: number to DraggableOptions TS interface

Changed

  • Fix mirror dimensions when constrainDimensions is active and not using fixed item width

v1.0.0-beta.9

Added

  • Added distance option
  • Added thresholdX and thresholdY mirror options

Changed

  • Fixes preventing of contextmenu in MouseSensor
  • Fixes SortableEvent over and overContainer giving incorrect properties
Changelog

Sourced from @​shopify/draggable's changelog.

1.0.0

Patch Changes

  • Adds changeset dependency for version management

v1.0.0-beta.13 - 2021-05-17

Added

  • Add mirror:moved event
  • Cancel Dragging on ESC key up

Changed

  • Fixes add missing exports DelayOptions and DelayOptions
  • Fixes return early when the target isn't in handle or draggable elements sensor
  • Fixes the argument type of the trigger method

v1.0.0-beta.12 - 2020-09-29

Added

  • Added drag:stopped event that will be fired after drag finished
  • Support specifying an array of class name to Draggable classes option

Changed

  • Fixes incorrect oldIndex value when working with nested sortable
  • Fixes wrong same container checking bug when working with nested sortable
  • Fixes bug drag:start event was triggered during the delay time
  • Fixes missing overContainer property in DragOutEvent

v1.0.0-beta.11 - 2020-07-14

Added

  • Added exclude option to allow disable default plugins and sensors
  • Added missing plugin types
  • Support set the type of callback function according to the event type

Changed

  • Fixes drag start concurrency (delay and distance options)
  • Fixes text in mirror blurry
  • Fixes accidently append mirror

v1.0.0-beta.10 - 2020-06-18

Added

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@shopify/draggable](https://github.com/Shopify/draggable) from 1.0.0-beta.8 to 1.0.0.
- [Release notes](https://github.com/Shopify/draggable/releases)
- [Changelog](https://github.com/Shopify/draggable/blob/main/CHANGELOG.md)
- [Commits](Shopify/draggable@v1.0.0-beta.8...v1.0.0)

---
updated-dependencies:
- dependency-name: "@shopify/draggable"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added javascript Pull requests that update Javascript code TAG: dependencies Pull requests that update a dependency file labels Sep 25, 2023
@rtibbles
Copy link
Member

I think these changes should be fine, but this needs to be tested in rearranging channels in the device plugin, rearranging resources in a lesson, and rearranging questions in a fixed order coaching quiz.

cc @radinamatic @pcenov

@pcenov pcenov self-requested a review September 25, 2023 08:37
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rtibbles unfortunately rearranging the order of channels, lesson resources or quiz questions is not working in any of the supported browsers.

2023-09-25_14-59-47.mp4

@rtibbles
Copy link
Member

Thanks for the due diligence, @pcenov!

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 26, 2023

Superseded by #11298.

@dependabot dependabot bot closed this Sep 26, 2023
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/shopify/draggable-1.0.0 branch September 26, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code SIZE: small TAG: dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants