Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed KContentRenderer to ContentRenderer. #11289

Merged
merged 3 commits into from
Sep 27, 2023

Conversation

ShivangRawat30
Copy link
Contributor

Summary

This PR Renames the KContentRenderer to ContentRenderer.

References

#11282

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) SIZE: small labels Sep 22, 2023
@MisRob MisRob added the TODO: needs review Waiting for review label Sep 23, 2023
Copy link
Member

@AllanOXDi AllanOXDi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rtibbles rtibbles changed the base branch from release-v0.16.x to develop September 26, 2023 14:54
@rtibbles
Copy link
Member

Retargeting to develop to avoid last minute changes in release.

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has not updated the name of the KContentRenderer component file:
https://github.com/learningequality/kolibri/blob/release-v0.16.x/kolibri/core/assets/src/views/ContentRenderer/KContentRenderer.js
Ideally this file would be renamed to index.js

Updates are also needed to references to it here: https://github.com/learningequality/kolibri/blob/release-v0.16.x/kolibri/core/assets/src/core-app/index.js#L16

With the above rename, the import can be changed to:

import ContentRenderer from '../views/ContentRenderer';

Signed-off-by: shivangrawat30 <[email protected]>
@ShivangRawat30
Copy link
Contributor Author

@rtibbles I have made the requested Changes, kindly review them.

@rtibbles rtibbles merged commit bf2563d into learningequality:develop Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants