-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed KContentRenderer to ContentRenderer. #11289
Conversation
Signed-off-by: shivangrawat30 <[email protected]>
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Retargeting to develop to avoid last minute changes in release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has not updated the name of the KContentRenderer component file:
https://github.com/learningequality/kolibri/blob/release-v0.16.x/kolibri/core/assets/src/views/ContentRenderer/KContentRenderer.js
Ideally this file would be renamed to index.js
Updates are also needed to references to it here: https://github.com/learningequality/kolibri/blob/release-v0.16.x/kolibri/core/assets/src/core-app/index.js#L16
With the above rename, the import can be changed to:
import ContentRenderer from '../views/ContentRenderer';
Signed-off-by: shivangrawat30 <[email protected]>
@rtibbles I have made the requested Changes, kindly review them. |
Summary
This PR Renames the
KContentRenderer
toContentRenderer
.References
#11282
Reviewer guidance
…
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)