Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable scroll on main page if side panel is open #11286

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

nikkuAg
Copy link
Contributor

@nikkuAg nikkuAg commented Sep 22, 2023

Summary

I have added a function that sets the position of the main wrapper to fixed when the side panel is open and resets it to null when the side panel is closed.

Initially:
https://github.com/learningequality/kolibri/assets/77184239/0ba285dc-c08e-49f6-9120-d1d48a6227e0

After adding the function:
https://github.com/learningequality/kolibri/assets/77184239/8ae95aac-c594-4e83-9268-d173de6e928f

References

#9095

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: small labels Sep 22, 2023
@MisRob MisRob added the TODO: needs review Waiting for review label Sep 22, 2023
Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, implemented as specified!

@rtibbles rtibbles merged commit 1c886dd into learningequality:release-v0.16.x Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants