Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 400 Bad Request Lesson Error #11279

Closed

Conversation

ozer550
Copy link
Member

@ozer550 ozer550 commented Sep 20, 2023

Summary

Fixes missing classId parameter while accessing create lesson route.
closes #11267

Reviewer guidance

  • Go to coach->plan->lesson
  • Try creating a lesson.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) SIZE: very small labels Sep 20, 2023
@ozer550 ozer550 changed the title Fix 400 Bad Request Lesson error Fix 400 Bad Request Lesson Error Sep 20, 2023
Copy link
Contributor

@thanksameeelian thanksameeelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i started out with a plan to test out this PR in all 4 possible scenarios - multi-facility user in a facility with 1 class, multi-facility user in a facility with more than 1 class, single facility user with 1 class, and single facility user with more than 1 class. i ended up experiencing an issue with the 1st & 2nd scenarios, so decided to pause my testing there for now.

in the case of a multi-facility user with any number of classes, choosing "New Lesson" seems to always send the user back to the "All Facilities" page instead of to lesson creation. i think this may just be an issue of adjusting the conditions in which the navigation guard is called for this route or the information that the guard is provided.

multifacilityuser-1class.mov

cc @rtibbles as he may have some insight!

@thanksameeelian
Copy link
Contributor

(closed since the issue has been taken up in PR #11283)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) SIZE: very small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken lesson creation
2 participants