Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 8532 replace text Truncator topics in TopicsMobileHeader.vue #11265

Conversation

muditchoudhary
Copy link
Contributor

@muditchoudhary muditchoudhary commented Sep 18, 2023

Summary

Replace the Texttruncator with TextTruncatorCss.

Before After
TopicsMobileHeaderBefore TopicsMobileHeaderAfter

Update the title for testing with chrome dev tools through inspect element. Don't know in Before why title is overflowing though fixed after using TextTruncatorCss

References

#8532

Reviewer guidance

To review:

  • Go to Learn --> Home --> Select Kolibri QA channel --> Videos --> Atomic Interactions in Chapters.
  • Toggle the device to a mobile screen.
  • The Atomic Interactions in Chapters is truncated.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: very small labels Sep 18, 2023
@MisRob MisRob added the TODO: needs review Waiting for review label Sep 19, 2023
@MisRob MisRob requested review from MisRob and pcenov September 19, 2023 12:46
@MisRob
Copy link
Member

MisRob commented Sep 19, 2023

Great PR description and guidance. And one extra bug fixed! Thank you, @muditchoudhary.

Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looking good. Let's wait for QA before merging.

@MisRob
Copy link
Member

MisRob commented Sep 19, 2023

Documentation check failure is a known issue and not related to this PR.

Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented as specified. Good to go!

@rtibbles rtibbles changed the base branch from develop to release-v0.16.x September 22, 2023 03:45
@rtibbles rtibbles force-pushed the issue-8532-replace-TextTruncator-TopicsMobileHeader branch from 8a5b34d to 65b525b Compare September 22, 2023 03:47
@rtibbles rtibbles merged commit 4e84fc9 into learningequality:release-v0.16.x Sep 22, 2023
34 checks passed
@muditchoudhary muditchoudhary deleted the issue-8532-replace-TextTruncator-TopicsMobileHeader branch September 28, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: very small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants