-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 8532 replace text Truncator topics in TopicsMobileHeader.vue #11265
Issue 8532 replace text Truncator topics in TopicsMobileHeader.vue #11265
Conversation
Build Artifacts
|
Great PR description and guidance. And one extra bug fixed! Thank you, @muditchoudhary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes looking good. Let's wait for QA before merging.
Documentation check failure is a known issue and not related to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented as specified. Good to go!
8a5b34d
to
65b525b
Compare
Summary
Replace the
Texttruncator
withTextTruncatorCss
.Update the title for testing with chrome dev tools through inspect element. Don't know in Before why title is overflowing though fixed after using TextTruncatorCss
References
#8532
Reviewer guidance
To review:
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)