Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reaplce TextTruncator with TextTruncatorCss in HybridLearningLessonCard.vue #11263

Conversation

muditchoudhary
Copy link
Contributor

@muditchoudhary muditchoudhary commented Sep 18, 2023

Summary

Replace the Texttruncator with TextTruncatorCss. The PR also removes the maxTitleHeight computed property.

Before After
HybridLearningLessonCardBefore HybridLearningLessonCardAfter

Update the title content for testing with chrome dev tools through inspect element

References

#8532

Reviewer guidance

To Review:

  • Go to Learn --> Home --> Select Kolibri QA channel. The video card (or other HybridLearningLessonCard) titles are Truncated.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: small labels Sep 18, 2023
@MisRob MisRob requested review from MisRob and pcenov September 19, 2023 12:44
@MisRob MisRob added the TODO: needs review Waiting for review label Sep 19, 2023
Copy link
Member

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @muditchoudhary. Code changes looking good. Let's wait for QA before merging.

@MisRob
Copy link
Member

MisRob commented Sep 19, 2023

Documentation check failure is a known issue and not related to this PR.

Copy link
Member

@pcenov pcenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rtibbles rtibbles force-pushed the issue-8532-replace-TextTruncator-HybridLearningLessonCard branch from a1527a6 to 0bdec15 Compare September 22, 2023 03:36
@github-actions github-actions bot added DEV: dev-ops Continuous integration & deployment DEV: backend Python, databases, networking, filesystem... APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) SIZE: medium labels Sep 22, 2023
@rtibbles rtibbles changed the base branch from develop to release-v0.16.x September 22, 2023 03:37
@rtibbles rtibbles force-pushed the issue-8532-replace-TextTruncator-HybridLearningLessonCard branch from 0bdec15 to d51a29c Compare September 22, 2023 03:45
@github-actions github-actions bot removed DEV: dev-ops Continuous integration & deployment DEV: backend Python, databases, networking, filesystem... APP: Device Re: Device App (content import/export, facility-syncing, user permissions, etc.) APP: Facility Re: Facility App (user/class management, facility settings, csv import/export, etc.) APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) APP: User Re: User app (sign-in, sign-up, user profile, etc.) APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) labels Sep 22, 2023
@rtibbles rtibbles merged commit 7316be7 into learningequality:release-v0.16.x Sep 22, 2023
34 checks passed
@muditchoudhary muditchoudhary deleted the issue-8532-replace-TextTruncator-HybridLearningLessonCard branch September 28, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) SIZE: small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants