-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reaplce TextTruncator with TextTruncatorCss in HybridLearningLessonCard.vue #11263
Reaplce TextTruncator with TextTruncatorCss in HybridLearningLessonCard.vue #11263
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @muditchoudhary. Code changes looking good. Let's wait for QA before merging.
Documentation check failure is a known issue and not related to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
a1527a6
to
0bdec15
Compare
0bdec15
to
d51a29c
Compare
Summary
Replace the
Texttruncator
withTextTruncatorCss
. The PR also removes themaxTitleHeight
computed property.Update the title content for testing with chrome dev tools through inspect element
References
#8532
Reviewer guidance
To Review:
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)